Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lantern: Improve performance opportunity estimates based on graphs #3618

Closed
patrickhulce opened this issue Oct 19, 2017 · 2 comments · Fixed by #4601
Closed

Lantern: Improve performance opportunity estimates based on graphs #3618

patrickhulce opened this issue Oct 19, 2017 · 2 comments · Fixed by #4601
Assignees

Comments

@patrickhulce
Copy link
Collaborator

The potential savings estimates currently just compute the milliseconds based solely on bytes saved. This leads to some confusion and misrepresentation since all ms are not created equal, i.e. shaving 1s off FMP means a lot more than saving 1s off the end of "all images have finished downloading"

We can use the fast mode graphs to predict how much time would be saved for each metric as well as overall savings

@patrickhulce patrickhulce changed the title FastMode: Improve performance opportunity estimates based on graphs Lantern: Improve performance opportunity estimates based on graphs Oct 27, 2017
@patrickhulce
Copy link
Collaborator Author

blocked on UX thinking here

@patrickhulce
Copy link
Collaborator Author

I am so stoked about how this is shaping up early. It's reranking things much more in line with how we intuitively think of biggest bang-for-buck performance. Improvements to files that are loaded early and dependencies of lots of resources now have the biggest impact whereas improvements to lazily-loaded images that are already as late as they should be have little to no impact.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants