--save-assets: kill off screenshots.html/screenshots.json

[paulirish]

AFAIK, we don't have any more customers of these.

@benschwarz @alekseykulikov

you guys good with this?

[benschwarz]

Yep. I'm not using the output of --save-assets.

[wardpeet]

@paulirish if we kill this of is their a manual way to get screenshots going?
Just wondering as I might need this in the future 😛

[patrickhulce]

@wardpeet yeah you'll still be able to fairly easily grab them from the trace :)

it's ~20 lines

[paulirish]

Yah. easy enough to restore the https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/gather/computed/screenshots.js computed artifact later if we need it again.

[wardpeet]

thanks for explaining, didn't knew how it worked actually

[wardpeet]

@paulirish i believe we can close this?

[brendankenny]

Not yet :)

lighthouse/lighthouse-core/lib/asset-saver.js

Lines 301 to 307 in 1ac7bd1

	const screenshotsHTMLFilename = `${pathWithBasename}-${index}.screenshots.html`;
	fs.writeFileSync(screenshotsHTMLFilename, passAssets.screenshotsHTML);
	log.log('saveAssets', 'screenshots saved to disk: ' + screenshotsHTMLFilename);
	const screenshotsJSONFilename = `${pathWithBasename}-${index}.screenshots.json`;
	fs.writeFileSync(screenshotsJSONFilename, JSON.stringify(passAssets.screenshots, null, 2));
	log.log('saveAssets', 'screenshots saved to disk: ' + screenshotsJSONFilename);

(we really should delete)

[paulirish]

fixed by #6066