Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: add toggle to report to filter all flagged resources to same-origin only / 3rd party / 3P #4516

Closed
patrickhulce opened this issue Feb 12, 2018 · 7 comments

Comments

@patrickhulce
Copy link
Collaborator

In audits like passive event listeners (#4434) we used to restrict to same-origin URLs but nearly all recent audits flag all resources. It might be nice to add the filtering at the report level instead so you can get a view with "easiest to fix first" and remove it from the audit level across the board.

cc @hwikyounglee in case you have thoughts here :)

@paulirish
Copy link
Member

paulirish commented Aug 27, 2018

We'd like to handle the impact of extensions consistently across this audit and the perf ones.

We plan to publish docs on why we wont auto-filter ext/3P results from the report, but will allow you to visually hide them (without recomputing score). One can always run in incognito to remove impact from extensions.

@paulirish paulirish changed the title Idea: add toggle to report to filter all flagged resources to same-origin only Idea: add toggle to report to filter all flagged resources to same-origin only / 3rd party / 3P Aug 29, 2018
@hwikyounglee
Copy link

Idea - add an indication of source location
3p

@patrickhulce
Copy link
Collaborator Author

didn't mean to steal this from you @wardpeet! just wanted to investigate what we'll run into before it was assigned to anyone. you're free to still handle it if you'd like :)

@wardpeet
Copy link
Collaborator

Haha, no worries feel free to take it

@patrickhulce
Copy link
Collaborator Author

I really think you should take this back @wardpeet :)

I don't think I'm going to get to it immediately, and it's a nice juicy important piece for ya 😃

@wardpeet
Copy link
Collaborator

recap before I start:
We will add a toggle to filter out all third party requests from our tables with a toggle button but we won't touch the scores.

This is what i'll add:

  1. a toggle button at the top that just hides all tables
  2. a toggle button for each table (audit) that has need of it.
  3. an indicator in each table to show that we have marked it as third party (i'm thinking of an icon with a tooltip instead of text (wdyt @hwikyounglee ?)
  4. We consider a request a third party when it doesn't matches it's root domain, am I correct?

🎉 thanks patrick for the PR!

@patrickhulce @paulirish @brendankenny did I miss anything?

@brendankenny
Copy link
Member

fixed in #6351!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants