-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea: add toggle to report to filter all flagged resources to same-origin only / 3rd party / 3P #4516
Comments
|
didn't mean to steal this from you @wardpeet! just wanted to investigate what we'll run into before it was assigned to anyone. you're free to still handle it if you'd like :) |
Haha, no worries feel free to take it |
I really think you should take this back @wardpeet :) I don't think I'm going to get to it immediately, and it's a nice juicy important piece for ya 😃 |
recap before I start: This is what i'll add:
🎉 thanks patrick for the PR! @patrickhulce @paulirish @brendankenny did I miss anything? |
fixed in #6351! |
In audits like passive event listeners (#4434) we used to restrict to same-origin URLs but nearly all recent audits flag all resources. It might be nice to add the filtering at the report level instead so you can get a view with "easiest to fix first" and remove it from the audit level across the board.
cc @hwikyounglee in case you have thoughts here :)
The text was updated successfully, but these errors were encountered: