Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only request pSI from speedline instead of all #4694

Closed
pmeenan opened this issue Mar 5, 2018 · 2 comments
Closed

Only request pSI from speedline instead of all #4694

pmeenan opened this issue Mar 5, 2018 · 2 comments

Comments

@pmeenan
Copy link

pmeenan commented Mar 5, 2018

It looks like only the perceptual speed index is used but both pSI and SI are calculated by default by speedline (and one of the slower parts of the audit). Passing Include.pSI as an option should restrict speedline to not calculate SI and speed up the audits.

Optionally, If SI is exposed in the UI, even though it is not part of the score aggregation it would be helpful to embedders to optionally not run the SI claculation.

@patrickhulce
Copy link
Collaborator

I believe we already made this optimization (#3845), but perhaps it's not working properly. Are you still seeing both computed in WPT?

@pmeenan
Copy link
Author

pmeenan commented Mar 5, 2018

Argh, sorry - misread the code.

@pmeenan pmeenan closed this as completed Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants