Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lighthouse 3 regression in user-timings details #5418

Closed
alekseykulikov opened this issue Jun 4, 2018 · 3 comments · Fixed by #5442
Closed

lighthouse 3 regression in user-timings details #5418

alekseykulikov opened this issue Jun 4, 2018 · 3 comments · Fixed by #5442

Comments

@alekseykulikov
Copy link
Contributor

Bug report

Lighthouse v3 does not provide startTime value for user timing measures. This info is the part of extendedInfo but it was removed.

Provide the steps to reproduce

  1. lighthouse https://treo.sh
  2. Check JSON report:
  "user-timings": {
      "id": "user-timings",
      "title": "User Timing marks and measures",
      "description": "Consider instrumenting your app with the User Timing API to create custom, real-world measurements of key user experiences. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/user-timing).",
      "score": null,
      "scoreDisplayMode": "informative",
      "rawValue": false,
      "displayValue": "2",
      "details": {
        "type": "table",
        "headings": [{
          "key": "name",
          "itemType": "text",
          "text": "Name"
        }, {
          "key": "timingType",
          "itemType": "text",
          "text": "Type"
        }, {
          "key": "time",
          "itemType": "ms",
          "granularity": 0.01,
          "text": "Time"
        }],
        "items": [{
          "name": "home did mount",
          "timingType": "Measure",
          "time": 49
        }, {
          "name": "boot",
          "timingType": "Mark",
          "time": 716.685
        }]
      }
    }

What is the current behavior?

The report contains only time value.

What is the expected behavior?

The report should contain startTime value for measures.

Environment Information

  • Affected Channels: All (report)
  • Lighthouse version: 3.0.0-beta.0

Related issues

#5402

@patrickhulce
Copy link
Collaborator

Good point thanks for reporting @alekseykulikov!

@patrickhulce
Copy link
Collaborator

Are there any other properties from user timings you need?

userTimings.push({
name: ut.name,
isMark: false,
args: ut.args,
startTime: measuresStartTimes[ut.name],
endTime: ut.ts,
duration: ut.ts - measuresStartTimes[ut.name],
});

@alekseykulikov
Copy link
Contributor Author

@patrickhulce No, only this one is missing. There are 4 properties for user timing: name, type , startTime and duration(only for measures).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants