Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show "potential savings of 0 ms" #5956

Closed
paulirish opened this issue Sep 4, 2018 · 2 comments
Closed

Don't show "potential savings of 0 ms" #5956

paulirish opened this issue Sep 4, 2018 · 2 comments
Labels
P1

Comments

@paulirish
Copy link
Member

if there's no savings (and especially since its a passing audit) we shouldn't have this displayText.
@paulirish paulirish added the P1 label Sep 4, 2018
@paulirish paulirish mentioned this issue Sep 5, 2018
Closed
@midzer
Copy link
Contributor

midzer commented Sep 6, 2018

For my test site this infotext shows only for Preconnect to required origins and Preload key requests
PR coming in a minute :>

@midzer midzer mentioned this issue Sep 7, 2018
Merged
@paulirish
Copy link
Member Author

fixed by #5983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulirish @midzer