Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cursor: pointer missing on Passed Audits #5958

Closed
paulirish opened this issue Sep 5, 2018 · 3 comments
Closed

cursor: pointer missing on Passed Audits #5958

paulirish opened this issue Sep 5, 2018 · 3 comments

Comments

@paulirish
Copy link
Member

In the report, it's clickable but we dont have cursor set on it. :/ should be fixed.

Probably applies to non-applicable and manual audit groups too.

@midzer
Copy link
Contributor

midzer commented Sep 5, 2018

Hi again :)
After playing around a little bit, I found a possible solution for overal convenient cursor behaviour:
For

.lh-audit__header,
.lh-audit-group--manual,
.lh-passed-audits,
.lh-audit-group--not-applicable

we could set cursor: pointer. Miserably this overrides their children and I think we don't want a pointer on non-clickable text. So we have to restore initial value for:

lh-audit-group__description,
lh-audit__description,
lh-details

Looking forward to start PR if you want to have a look on this one.

Have a nice week
midzer

@brendankenny
Copy link
Member

@paulirish fixed?

@paulirish
Copy link
Member Author

fixed by #5977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants