Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a run of theverge.com takes 85s #6067

Closed
3 tasks done
paulirish opened this issue Sep 19, 2018 · 6 comments
Closed
3 tasks done

a run of theverge.com takes 85s #6067

paulirish opened this issue Sep 19, 2018 · 6 comments
Labels

Comments

@paulirish
Copy link
Member

paulirish commented Sep 19, 2018

image

A few things in here we can look into

@paulirish
Copy link
Member Author

gatherTrace takes 17s!! @exterkamps's #6056 might be our savior here

from 17s to 5s. OH YEAHHHHHHHH. 🎊🎊

@brendankenny
Copy link
Member

brendankenny commented Sep 19, 2018

speedline > paulirish/speedline#70

@brendankenny
Copy link
Member

brendankenny commented Sep 20, 2018

replaceIcuMessageInstanceIds > #6072

@patrickhulce
Copy link
Collaborator

idle periods not triggering on this run

Core problem here seems to be that for iframe documents we never end up getting a loadingFinished message, just the response received. I'll do a workaround similar to the QUIC situation but should probably look into if this was a recent change or why it was just being masked before.

@paulirish
Copy link
Member Author

with #6078 taken care of, we call this closed.

From 85s ➡️ 16s!

srs team effort. nice one y'all!

@brendankenny
Copy link
Member

🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants