Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mobile viewport size to match Nexus 5X #6615

Closed
mattzeunert opened this issue Nov 20, 2018 · 0 comments · Fixed by #6932
Closed

Change mobile viewport size to match Nexus 5X #6615

mattzeunert opened this issue Nov 20, 2018 · 0 comments · Fixed by #6932
Assignees

Comments

@mattzeunert
Copy link
Contributor

Lighthouse uses a resolution of 412x732 for the mobile setting, but we're trying to match the Nexus 5X viewport size which is only 412x660 (because of the phone chrome around it).

@patrickhulce said we might be able to change it. One upside would be that we could tell users to use Chrome's Nexus 5X emulation settings to test viewport-specific audit results, e.g. tap target sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants