Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't warn about wrong image aspect ratio if image has object-fit: scale-down css property #6760

Closed
dima74 opened this issue Dec 9, 2018 · 1 comment
Closed

Don't warn about wrong image aspect ratio if image has object-fit: scale-down css property #6760

dima74 opened this issue Dec 9, 2018 · 1 comment
Labels
good first issue

Comments

@dima74
Copy link
Contributor

dima74 commented Dec 9, 2018

Provide the steps to reproduce

  1. Run LH on https://s.codepen.io/dima74/debug/roNjpa/LQAExKwgYvKr

What is the current behavior?

Warning Image display dimensions should match natural aspect ratio.

What is the expected behavior?

No warning, because image has object-fit: scale-down; css property, so different aspect ratio is intentional.

Proposed solution

Add check for scale-down here. Probably none value also should be added.

Environment Information

  • Affected Channels: DevTools
  • Lighthouse version: 3.2.0
  • Node.js version: 11.3.0
  • Operating System: Linux
@patrickhulce
Copy link
Collaborator

Thanks for filing @dima74! Want to work on a PR? :)

@dima74 dima74 mentioned this issue Dec 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patrickhulce @dima74