-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update throttling/cache/js state on the SW target #709
Comments
Current status: SW not affected by network throttling status or JS disabling of host page. update: Or disk cache |
I believe this would also let us solve #2688 more easily, since we could more easily simulate a fetch with mode |
⭐️ Re-read the comments on #3237, useful stuff there. |
Deferring until new |
Any news about this? It's blocking #2688. Thanks in advance! |
We finally have the pieces in place to make this happen with the basic driver target management we're doing. IMO, we should re-prioritize this after 5.0 :) |
Thank you for opening this bug. It looks like we've managed to merge #9451 which should fix this bug. I am closing it for now but please feel free to reopen this and comment if you would like to continue this discussion. |
this is actually a big one even apart from the offline part of it. We should keep it around :) |
Thanks for reopening :) I'm currently drafting a doc which i'll share soonish with all issues i'm unsure about. |
Hi, is there any timeline for this to be resolved? This is needed for Lighthouse in DevTools to properly show emulated mobile results when the navigation request is being served through the SW's fetch event. Currently it loads the desktop site while emulating mobile due to sending the desktop user agent from the Service Worker. |
@Joelsz the offline check isn't computed by lighthouse anymore in 7.0 and later, so this issue shouldn't affect that result in latest. |
Thanks @patrickhulce for your reply. This is not only about the offline check, it's about all the audits being checked against the desktop site. Even with LH 7 (in Chrome 90) the SW sends the desktop UA while emulating mobile, thus loading the desktop site and calculating the audit result against that instead of the mobile site. I don't understand though why this is only happening during Lighthouse execution, while the mobile site is properly loaded when pressing the browser reload button even though it's also using the same SW "fetch" handler. |
Ah I see. Thanks for the clarification @Joelsz ! |
In Developer Diary #Day1 - YouTube @paullewis ran into a weird behavior that the Service Worker wasnt going offline, despite Lighthouse making the page offline. It was filed as crbug 648208, and duped into a WontFix, as the devtools frontend handles this case decently well. The frontend will connect to both targets and send the network throttling commands to each.
In our current behavior ...
Currently Lighthouse only sends the throttling stuff to the page's target. It'd make sense to also connect to the SW and flip it offline etc.
The text was updated successfully, but these errors were encountered: