-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider always filtering configs to allow extra gatherers that won't run by default #7787
Labels
Comments
would want a way to cancel this behavior: ex: I am using lh to gather artifacts and don't really care about the audits (idk maybe someone does this). |
We'll make sure to handle this as part of #11313 for automatic filtering in modes, but we won't be pursuing this in current Lighthouse gathering flow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now we only filter configs when
onlyAudits
,onlyCategories
, orskipAudits
are set.Some of the proposed plugins will need a gatherer. It seems ok to include in core if they're generally useful (e.g. the proposed
IFrameElements
), but they are doing unnecessary work in the default case since no audits depend on their output.If we do filter configs by default (essentially setting
--onlyAudits=[...defaultAudits]
if no other filter flags are set), that would allow us to keep those extra gatherers in the default config with no overhead since they'll be filtered out in the usual case. Then running plugins wouldn't require a custom config (only--plugins lighthouse-plugin-whatever
flag).Downsides/caveats:
default-config.js
(you'd need to run--print-config
to see what will actually happen)(so I'm not 100% sold on this yet, but it would have benefits)
The text was updated successfully, but these errors were encountered: