-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include apple-touch-icon
in PWA icon requirements
#7890
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
iOS PWAs are a thing! Right now mobile safari doesn't use the
icons
defined in the web manifest and instead uses the<link rel="apple-touch-icon" href="apple-touch-icon.png">
for the PWA homescreen icon.We should include this in the PWA checks.
Firt said "The test should check probably presence, icon size and the absence of transparent colors on it 🙄"
webhint checks some of these aspects: https://webhint.io/docs/user-guide/hints/hint-apple-touch-icons/
thread with firt: https://twitter.com/paul_irish/status/1112791885246951424
Related to icons, we could also check for
<link rel="apple-touch-startup-image" href="/launch.png">
which is the image used in the splash screen. Unfortunately, the png asset has to be the same size as the device screen, which leads to a bunch of ugly tags. Let's hold off on this part until we get guidance from the Safari team.Related: https://developers.google.com/web/updates/2018/07/pwacompat for all sorts of crossbrowser PWA compat
Slightly related bug: #6700 for changing the icon size requirements
The text was updated successfully, but these errors were encountered: