Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt new Page.getInstallabilityErrors method for PWA checks #8223

Closed
paulirish opened this issue Apr 12, 2019 · 3 comments
Closed

Adopt new Page.getInstallabilityErrors method for PWA checks #8223

paulirish opened this issue Apr 12, 2019 · 3 comments
Assignees

Comments

@paulirish
Copy link
Member

https://chromium-review.googlesource.com/c/chromium/src/+/1560533
https://chromedevtools.github.io/devtools-protocol/tot/Page#method-getInstallabilityErrors

It tests against the real implementation, so we won't have a gap.
https://cs.chromium.org/chromium/src/chrome/browser/installable/installable_logging.cc?l=15-57

This also means we can probably drop manifest parser, manifest-values, etc.
Their offline check is a little different though.

The strings returned are hardcoded english.. but then again so are our current strings. ;)

@connorjclark
Copy link
Collaborator

connorjclark commented May 19, 2019

Won't be able to drop manifest-values completely, as many checks aren't handled via the protocol. Example - background color, theme color, icons >= 512px. Which makes sense, the protocol method name suggests it only checks the must haves.

@connorjclark
Copy link
Collaborator

@paulirish
Copy link
Member Author

now a dupe of #10515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants