New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StackPack icon doesn't survive proto round trip #8537

Closed

exterkamp opened this issue Apr 23, 2019 · 0 comments · Fixed by #8536

Labels

Member

exterkamp commented Apr 23, 2019

Icon data URL doesn't make it through a proto round trip because it is named differently in ts and proto. URL != Url

/** A base64 data url to be used as the stack pack's icon. */
iconDataURL: string;

// The icon as a data url.
string icon_data_Url = 3;

exterkamp mentioned this issue

core(stackpacks): proto uses icon_data_URL and stackPack test #8536

Merged

paulirish added the needs-priority label

brendankenny closed this as completed in #8536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment