Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lightwallet] Support timings in budgets UI #8917

Closed
Danon9111 opened this issue May 10, 2019 · 4 comments
Closed

[Lightwallet] Support timings in budgets UI #8917

Danon9111 opened this issue May 10, 2019 · 4 comments

Comments

@Danon9111
Copy link

How timings budgets are shown in case when they are not met?

Could you please confirm that currently budget for timings metrics are working properly? As I see right now in html report is no clear information about if the budget have been met.

Budget definition:
image

Steps to reproduce

  1. Run lighthouse https://youtube.com --budget-path=lighthouse-core/test/fixtures/simple-budget.json in console (CMD or GitBash on Windows)
  2. Open generated report

Current behavior:
Generated HTML report does not have clear information about timings budget, like for resourceSizes.

Report:
image

Question:
Is described behavior an expected one? Or for timings should be also displayed table with information about current value of metric and expected budget, defined in json file like in case of resources?

@patrickhulce
Copy link
Collaborator

Budgets only assert on the file sizes at the moment, metric timings are pending so stay tuned :)

@patrickhulce patrickhulce changed the title [Question] How timings budgets are shown in case when they are not met? Support timings in budgets UI May 10, 2019
@Danon9111
Copy link
Author

Cool stuff!

Thank you for answer @patrickhulce !

Do you have any public roadmap to view what features can come next months?

@patrickhulce
Copy link
Collaborator

@Danon9111 not that's neatly organized into releases but you can take a look at issues with the P1 and P1.5 label to get an idea :)

@connorjclark
Copy link
Collaborator

fixed by #9925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants