-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lightwallet] Support timings in budgets UI #8917
Labels
Comments
Budgets only assert on the file sizes at the moment, metric timings are pending so stay tuned :) |
patrickhulce
changed the title
[Question] How timings budgets are shown in case when they are not met?
Support timings in budgets UI
May 10, 2019
Cool stuff! Thank you for answer @patrickhulce ! Do you have any public roadmap to view what features can come next months? |
@Danon9111 not that's neatly organized into releases but you can take a look at issues with the |
patrickhulce
changed the title
Support timings in budgets UI
[Lightwallet] Support timings in budgets UI
May 13, 2019
This was referenced Oct 30, 2019
fixed by #9925 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
How timings budgets are shown in case when they are not met?
Could you please confirm that currently budget for timings metrics are working properly? As I see right now in html report is no clear information about if the budget have been met.
Budget definition:
Steps to reproduce
lighthouse https://youtube.com --budget-path=lighthouse-core/test/fixtures/simple-budget.json
in console (CMD or GitBash on Windows)Current behavior:
Generated HTML report does not have clear information about timings budget, like for resourceSizes.
Report:
Question:
Is described behavior an expected one? Or for timings should be also displayed table with information about current value of metric and expected budget, defined in json file like in case of resources?
The text was updated successfully, but these errors were encountered: