Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline pass doesn't always go offline #9450

Closed
patrickhulce opened this issue Jul 24, 2019 · 4 comments · Fixed by #9451
Closed

Offline pass doesn't always go offline #9450

patrickhulce opened this issue Jul 24, 2019 · 4 comments · Fixed by #9451

Comments

@patrickhulce
Copy link
Collaborator

Provide the steps to reproduce

  1. Run LH on https://www.bhphotovideo.com/

What is the current behavior?

Lighthouse reports that the start URL does not load offline but the current page does.

You can observe that in the offline pass, the desktop version of the page is loaded, and upon inspecting lighthouse internals see that the fromServiceWorker and fromDiskCache flags on all network requests are false. This shouldn't be possible when offline.

What is the expected behavior?

Lighthouse reports that the start URL loads offline. A page like the below should be visible during the offline pass, not the desktop version of the site.

image

Environment Information

  • Affected Channels: CLI
  • Lighthouse version: 5.2.0
  • Node.js version: v10.15.3
  • Operating System: macOS

Related issues
brought over from #2688 (comment)

@brendankenny
Copy link
Member

possibly the same as #6502?

@brendankenny
Copy link
Member

well, almost the opposite situation, actually, but the same underlying cause? :)

@patrickhulce
Copy link
Collaborator Author

I don't think so, I found this root cause of this one and am working on a PR now. It was introduced ~February of this year by me :)

but could be more to unravel here!

@martinschierle
Copy link

stargames.de is having the same problem - page loads well offline, but Lighthouse states it wouldn't:

https://www.webpagetest.org/lighthouse.php?test=190827_Z0_86c8da0d29fd514bd77a00b7b760bb5b&run=3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants