Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ID of scripts in ScriptElements #9681

Closed
umair66 opened this issue Sep 16, 2019 · 2 comments
Closed

Expose ID of scripts in ScriptElements #9681

umair66 opened this issue Sep 16, 2019 · 2 comments
Labels

Comments

@umair66
Copy link

umair66 commented Sep 16, 2019

Feature request summary
Add an id key to the script objects in the ScriptElements array which is requested in the audit.

Currently available keys are type, src, async, defer, source, devToolsNodePath, content, requestID
Request to add the id key as well.

What is the motivation or use case for changing this?
This will make it easy to work with the specific script element of interest and a convenient way to select it.

How is this beneficial to Lighthouse?
Ease of use when working with ScriptElements while writing an audit.

@paulirish
Copy link
Member

sure adding the id is fine. this is for a plugin?

you wanna write the pull request?

@umair66
Copy link
Author

umair66 commented Sep 18, 2019

Yessir it's for a plugin. I'll write the pull request 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants