Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Error in code example under enable-https/#make-intrasite-urls-relative #10167

Closed
pnavarrc opened this issue Jun 18, 2023 · 1 comment · May be fixed by #10168
Closed

Error in code example under enable-https/#make-intrasite-urls-relative #10167

pnavarrc opened this issue Jun 18, 2023 · 1 comment · May be fixed by #10168
Labels
P2 A normal priority task. This is the default for most issues.

Comments

@pnavarrc
Copy link
Contributor

pnavarrc commented Jun 18, 2023

Describe the bug
A clear and concise description of what the bug is.

The last example in the section Make intrasite URLs relative has the <b> tag in the href attribute of a link. Also, the opening < of the paragraph element is escaped:

<h1>Welcome To Example.com</h1>
<script src="/jquery.js"></script>
<link rel="stylesheet" href="/assets/style.css"/>
<img src="/images/logo.png"/>;
<p>A <a href="/2014/12/24/">new post on cats!</a></p>
&lt;p>Check out this <a href="<b>https://foo.com/</b>">other cool site.</a></p> ← HERE

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://web.dev/enable-https/#make-intrasite-urls-relative
  2. Review the last code example in the section (the "Do" example labeled "Use HTTPS URLs for intersite URLs (where possible).")
  3. See that the last link has an incorrect href attribute

Expected behavior
A clear and concise description of what you expected to happen.

The example should be

<h1>Welcome To Example.com</h1>
<script src="/jquery.js"></script>
<link rel="stylesheet" href="/assets/style.css"/>
<img src="/images/logo.png"/>;
<p>A <a href="/2014/12/24/">new post on cats!</a></p>
<p>Check out this <a href="https://foo.com/"><b>other cool site.</b></a></p>

Screenshots
If applicable, add screenshots to help explain your problem.

image
@pnavarrc pnavarrc added the P2 A normal priority task. This is the default for most issues. label Jun 18, 2023
@dstmarthe
Copy link
Collaborator

Thanks for raising this. We’re moving to a new platform and so we’ll fix this over there. I’ve moved the issue to our new tracker and you can see it at https://issuetracker.google.com/issues/297890504

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 A normal priority task. This is the default for most issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants