Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BroadcastCacheUpdate from within Precaching? #1073

Closed
jeffposnick opened this issue Nov 28, 2017 · 4 comments
Closed

Use BroadcastCacheUpdate from within Precaching? #1073

jeffposnick opened this issue Nov 28, 2017 · 4 comments

Comments

@jeffposnick
Copy link
Contributor

Library Affected:
workbox-precaching

In v2, we implicitly used workbox-broadcast-cache-update as part of workbox-precaching's RequestWrapper, and announced changes to precached resources via a standard channel name.

We're not doing this in v3 right now. I'd argue that it's useful in theory, but at the same time, I don't think developers really took advantage to it, and there's obviously a hit in terms of extra runtime code.

We could:

  • Not implement this in v3.
  • Implement it by default in v3, matching v2's behavior.
  • Implement as an opt-in in v3. (I'm assuming that we'd still take the hit in default bundle size if we took that approach?)
@gauntface
Copy link

I don't think there is currently a way to add plugins, so I would be in favor of making that possible in the default precaching export and just provide a guide that explained how and why you would do this.

how does that sound?

@jeffposnick
Copy link
Contributor Author

Are you suggesting the third option that I listed? Would we avoid the bundle size hit if we went with that approach?

@gauntface
Copy link

@jeffposnick Yes the third option

@gauntface
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants