Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--watch option for CLI #1490

Closed
bennypowers opened this issue May 22, 2018 · 3 comments
Closed

--watch option for CLI #1490

bennypowers opened this issue May 22, 2018 · 3 comments
Labels
Developer Experience Related to ease of use for developers. Feature Request Good First Issue This would be an ideal issue for a new contributor to take on. workbox-cli
Milestone

Comments

@bennypowers
Copy link

Library Affected:
workbox-cli

Browser & Platform:
All Browsers - development on Linux, Windows, Mac, Haiku ;)

Issue or Feature Request Description:
Please consider adding a --watch flag to workbox-cli which would rebuild the service worker when watched files change.

@jeffposnick jeffposnick added Developer Experience Related to ease of use for developers. Feature Request workbox-cli labels Jun 16, 2018
@jadjoubran jadjoubran added the Good First Issue This would be an ideal issue for a new contributor to take on. label Nov 26, 2018
@jeffposnick
Copy link
Contributor

Just to clarify here: you'd like a rebuild triggered when any of the files that match the specified glob patterns change, right?

What if there's an additional file that's added after --watch has been invoked and which matches the pattern—should that also trigger a rebuild? (And if it didn't trigger a rebuild, would you consider that a bug?)

@jeffposnick
Copy link
Contributor

https://github.com/gulpjs/glob-watcher has pretty much drop-in support for what's currently being configured in globPatterns/globDirectory/globIgnore, so I'm going to assume that the expected behavior is just to pass those in and do whatever you'd get by default.

@jeffposnick jeffposnick added this to the v4 milestone Nov 30, 2018
@bennypowers
Copy link
Author

@jeffposnick Thanks for visiting this issue. Yes, I'm happy to defer semantics to whichever popular package. Chokidar or watchman are other options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Experience Related to ease of use for developers. Feature Request Good First Issue This would be an ideal issue for a new contributor to take on. workbox-cli
Projects
None yet
Development

No branches or pull requests

4 participants