Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing possibility to apply modifyUrlPrefix or manifestTransforms to all automatically added assets as well #1580

Closed
antony-k1208 opened this issue Jul 20, 2018 · 1 comment

Comments

@antony-k1208
Copy link

antony-k1208 commented Jul 20, 2018

Library Affected:
workbox-webpack-plugin

Browser & Platform:
all platforms

Issue or Feature Request Description:
We are currently stumbling upon a problem with this automatic generation of a precache manifest that contains URLs for assets created by the current webpack compilation. This is all fine, but the entries urls are totally unusable for our setup. It seems workbox-webpack-plugin is using webpacks output.path setting followed by other options made inside our webpack.config.

What we get is something like this:

{
    "revision": "51b9703cbbf90b6ca05a1b58e4e85051",
    "url": "../fonts/daxot-condbold-webfont.ttf"
  }

What we need is a possibility to apply something like the provided options modifyUrlPrefix or manifestTransforms which will also be applied to this automatic generation as well and not only to additional assets in order to get something like this:

{
    "revision": "51b9703cbbf90b6ca05a1b58e4e85051",
    "url": "ui/theme/fonts/daxot-condbold-webfont.ttf"
  }

With gulp and workbox-build we were able by using globDirectory, globPatterns and manifestTransforms to achieve exactly that behaviour.

Any help would be gladly appreciated.

Regards,
Antony

@jeffposnick
Copy link
Contributor

Thanks, Antony.

That's planned for the next major release of workbox-webpack-plugin, and tracked in #1227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants