Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setDefaultHandler/setCatchHandler need to be exposed on workbox.routing #1897

Closed
jeffposnick opened this issue Feb 12, 2019 · 0 comments
Closed

setDefaultHandler/setCatchHandler need to be exposed on workbox.routing #1897

jeffposnick opened this issue Feb 12, 2019 · 0 comments
Assignees
@jeffposnick
Labels
Bug An issue with our existing, production codebase. workbox-routing

Comments

@jeffposnick
Copy link
Contributor

As mentioned at https://stackoverflow.com/questions/54651722, you can't currently call workbox.routing.setCatchHandler() (or setDefaultHandler()) using the bundled modules.

I believe that's due to #1831, and we need to follow the same model used elsewhere in workbox-routing/index.mjs to export those methods, acting on the default router.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffposnick jeffposnick

Labels
Bug An issue with our existing, production codebase. workbox-routing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeffposnick