Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

findMatchingRoute (Router.ts) docs are missing the sameOrigin parameter #2782

Closed
cebjyre opened this issue Mar 16, 2021 · 0 comments · Fixed by #2783
Closed

findMatchingRoute (Router.ts) docs are missing the sameOrigin parameter #2782

cebjyre opened this issue Mar 16, 2021 · 0 comments · Fixed by #2783

Comments

@cebjyre
Copy link

cebjyre commented Mar 16, 2021

Library Affected:
workbox-routing

Browser & Platform:
all browsers (or none?)

Issue or Feature Request Description:
The change to add the sameOrigin parameter to router checks (#2505) updated the code for findMatchingRoute, but not the documentation block immediately above it - expand the context above https://github.com/GoogleChrome/workbox/pull/2505/files#diff-d5f776d2af13bb6daa2b3a1d595cb3c9ef4825b91398af155235237767e6d9e9R271 and note the presence of the options.url, options.request, and options.event parameters, but missing options.sameOrigin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JSDoc fix for sameOrigin GoogleChrome/workbox
1 participant
@cebjyre