Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events for multiple "external" service worker updates are not triggered #2850

Closed
mswysocki opened this issue May 24, 2021 · 2 comments
Closed
Labels
Bug An issue with our existing, production codebase. workbox-window

Comments

@mswysocki
Copy link

Welcome! Please use this template for reporting bugs or requesting features. For questions about using Workbox, the best place to ask is Stack Overflow, tagged with [workbox]: https://stackoverflow.com/questions/ask?tags=workbox

Library Affected:
workbox-window

Browser & Platform:
all browsers

Issue or Feature Request Description: When there are multiple stacked new service workers, the activated event is newer sent. This is because the event listener is removed after the first new service worker is received: https://github.com/GoogleChrome/workbox/blob/v6/packages/workbox-window/src/Workbox.ts#L379. Subscriptions for new service workers are never created for state change events.

When reporting bugs, please include relevant JavaScript Console logs and links to public URLs at which the issue could be reproduced.

@jeffposnick
Copy link
Contributor

Thanks—conceptually this is the same type of change as what's described at #2817 for controlling—we can make both those changes.

@jeffposnick jeffposnick added Bug An issue with our existing, production codebase. workbox-window labels May 24, 2021
@jeffposnick jeffposnick changed the title Events for multiple stacked service worker updates are not subscribed to. Events for multiple "external" service worker updates are not triggered Jul 9, 2021
@tomayac
Copy link
Member

tomayac commented Apr 25, 2024

Hi there,

Workbox is moving to a new engineering team within Google. As part of this move, we're declaring a partial bug bankruptcy to allow the new team to start fresh. We realize this isn't optimal, but realistically, this is the only way we see it working. For transparency, here're the criteria we applied:

Thanks, and we hope for your understanding!
The Workbox team

@tomayac tomayac closed this as completed Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An issue with our existing, production codebase. workbox-window
Projects
None yet
Development

No branches or pull requests

3 participants