Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with cacheFirst + maxAgeSeconds for CORS resource #691

Closed
jeffposnick opened this issue Jul 20, 2017 · 0 comments · Fixed by #694
Closed

Issue with cacheFirst + maxAgeSeconds for CORS resource #691

jeffposnick opened this issue Jul 20, 2017 · 0 comments · Fixed by #694
Assignees
Labels
Bug An issue with our existing, production codebase.

Comments

@jeffposnick
Copy link
Contributor

Library Affected:
workbox-cache-expiration

Browser & Platform:
Chrome, and others

Issue or Feature Request Description:
@pbakaus reported an issue in which a route for a CORS resource that uses cacheFirst + maxAgeSeconds isn't behaving like it should. The configuration is https://github.com/ampproject/amp-publisher-sample/blob/master/amp-pwa-reader/src/sw.js#L18, and a live example is at https://amp.cards/

From what I can tell, the original response is reused indefinitely, instead of expiring after 5 minutes have passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An issue with our existing, production codebase.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant