Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add fetchDidSucceed method to requestWrapper #788

Closed
weeblr opened this issue Sep 7, 2017 · 4 comments
Closed

Feature: Add fetchDidSucceed method to requestWrapper #788

weeblr opened this issue Sep 7, 2017 · 4 comments
Labels
Discuss An open question, where input from the community would be appreciated. workbox-core
Milestone

Comments

@weeblr
Copy link

weeblr commented Sep 7, 2017

Per this discussion https://stackoverflow.com/questions/46026849/postprocess-page-content-with-stalewhilerevalidate/

and @jeffposnick response, adding a method to allow modifying the response in all cases (ie fetched from network or fetched from cache).

Currently, it is not possible to modify a response that was obtained from the network, only when it was obtained from the cache.

@gauntface
Copy link

@weeblr sorry for being so quiet on this issue.

Use case here is having the ability to inject some JS into all pages.

@weeblr
Copy link
Author

weeblr commented Oct 17, 2017

@gauntface No problem. Not sure your comment is a question or not.

My current use case is to inject javascript, but it could be any sort of page content modification I guess.

@gauntface gauntface added the Discuss An open question, where input from the community would be appreciated. label Nov 1, 2017
@gauntface
Copy link

Just o update - this is unlikely to get addressed in V3 so will leave as a discuss label - but it's unlikely to get attention until V3 is launched, sorry about that.

@weeblr
Copy link
Author

weeblr commented Nov 2, 2017

Thanks for the update. Was not aware of v3 nearing release. Is there a place where I can follow progress and see announcements, a specific github issue?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discuss An open question, where input from the community would be appreciated. workbox-core
Projects
None yet
Development

No branches or pull requests

4 participants