Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Router.registerRoutes()/unregisterRoutes() methods #856

Closed
jeffposnick opened this issue Oct 6, 2017 · 3 comments
Closed

Remove Router.registerRoutes()/unregisterRoutes() methods #856

jeffposnick opened this issue Oct 6, 2017 · 3 comments
Assignees
@jeffposnick
Labels
Breaking Change Denotes a "major" semver change.

Comments

@jeffposnick
Copy link
Contributor

Library Affected:
workbox-routing

See #854 (comment)
@jeffposnick jeffposnick added the Breaking Change Denotes a "major" semver change. label Oct 6, 2017
@jeffposnick jeffposnick self-assigned this Oct 6, 2017
@jeffposnick jeffposnick mentioned this issue Oct 6, 2017
Merged
@gauntface
Copy link

Personally I'm in favor of this, although not super strongly opinionated.

Main reason is that I'm not aware of anyone wanting or using this.

@jeffposnick
Copy link
Contributor Author

I'll update #854 to account for that.

@jeffposnick
Copy link
Contributor Author

This was done in #854.

@dependencies dependencies bot mentioned this issue Mar 19, 2018
Open
@renovate renovate bot mentioned this issue Jun 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffposnick jeffposnick

Labels
Breaking Change Denotes a "major" semver change.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gauntface @jeffposnick