Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router.addFetchListener() deprecated—document new behavior #914

Closed
jeffposnick opened this issue Oct 17, 2017 · 1 comment
Closed

Router.addFetchListener() deprecated—document new behavior #914

jeffposnick opened this issue Oct 17, 2017 · 1 comment
Assignees
@jeffposnick
Labels
Breaking Change Denotes a "major" semver change. workbox-routing

Comments

@jeffposnick
Copy link
Contributor

Library Affected:
workbox-routing

Router.addFetchListener() was in v2, and has been removed in v3 (unless that decision is reversed in #913).

We need to also explain in the docs that folks need to either create their own fetch handler, or use the default export.
@jeffposnick jeffposnick added Breaking Change Denotes a "major" semver change. v3 workbox-routing labels Oct 17, 2017
@jeffposnick jeffposnick self-assigned this Oct 17, 2017
@jeffposnick jeffposnick changed the title Router.addFetchListener() deprecated Router.addFetchListener() deprecated—document new behavior Oct 17, 2017
@gauntface gauntface added this to the V3 milestone Oct 18, 2017
@philipwalton philipwalton mentioned this issue Oct 19, 2017
Closed
@gauntface
Copy link

This is covered in the Module Docs for workbox routing that will be published here: https://developers.google.com/web/tools/workbox/modules/workbox-routing

@dependencies dependencies bot mentioned this issue Mar 19, 2018
Open
@renovate renovate bot mentioned this issue Jun 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffposnick jeffposnick

Labels
Breaking Change Denotes a "major" semver change. workbox-routing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gauntface @jeffposnick