Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for 'fastest' as alias for StaleWhileRevalidate in runtimeCaching config #915

Closed
jeffposnick opened this issue Oct 17, 2017 · 1 comment
Assignees
Labels
Breaking Change Denotes a "major" semver change. workbox-build

Comments

@jeffposnick
Copy link
Contributor

Welcome! Please use this template for reporting bugs or requesting features. For questions about using Workbox, the best place to ask is Stack Overflow, tagged with [workbox]: https://stackoverflow.com/questions/ask?tags=workbox

Library Affected:
workbox-build

We previously supported using the string 'fastest' as a valid handler name in workbox-build's runtimeCaching config. This was to aid in the migration from sw-toolbox to Workbox.

I think it makes sense to just drop that alias in v3, especially since there are other explicit steps that need to be taken to migrate.

@jeffposnick jeffposnick added Breaking Change Denotes a "major" semver change. v3 workbox-build labels Oct 17, 2017
@jeffposnick jeffposnick self-assigned this Oct 17, 2017
@gauntface gauntface added this to the V3 milestone Oct 18, 2017
@jeffposnick
Copy link
Contributor Author

jeffposnick commented Nov 29, 2017

This is effectively done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Denotes a "major" semver change. workbox-build
Projects
None yet
Development

No branches or pull requests

2 participants