Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce https manifest URL #832

Open
joycetoh8 opened this issue Oct 19, 2023 · 1 comment
Open

Enforce https manifest URL #832

joycetoh8 opened this issue Oct 19, 2023 · 1 comment
Assignees

Comments

@joycetoh8
Copy link
Collaborator

For ChromeOS, https should be enforced for the manifest URL as PWAs are not allowed to use http. If a http manifest URL is used to create a TWA via Bubblewrap, ChromeOS will install the PWA with http causing a weird launch behavior from Play.

@joycetoh8 joycetoh8 self-assigned this Oct 19, 2023
@andreban
Copy link
Member

andreban commented Oct 20, 2023

Adding some more details:

To allow both things, It seems that separating the URL used to bootstrap the app from the webManifestURL would be the best way to go.

My proposed solution would be to ask the developer for the Manifest URL when creating the application, using the one provided to bootstrap it as default, and validate if it is HTTPS when doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants