Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] UI doesn't revert to original style after users click Toggle All and repeats the action #374

Closed
kjnanda opened this issue Dec 29, 2023 · 6 comments · Fixed by #401
Closed
Assignees
Labels
bug Something isn't working PSAT Features and tasks related to DevTools extension
Milestone

Comments

@kjnanda
Copy link

kjnanda commented Dec 29, 2023

To Reproduce

Steps to reproduce the behavior:

  1. Open PSAT from DevTools
  2. Visit any frame
  3. Right click on any column header
  4. Click on "Toggle All" option
  5. Now, there will be only on column present with "Name"
  6. To get all the columns back, again right click on "Name" column and click on "Toggle All" option
  7. Observe UI which is completely distorted.

Expected behavior
The table columns should get its original style

Screenshots

Screen.Recording.2023-12-29.at.16.37.48.mov
Test Environment
1. Chrome - New instance
2. Chrome version: - Version 120.0.0.0 (arm64)
3. OS - MacOS (arm64)
4. PSAT - V0.4.0

@maitreyie-chavan maitreyie-chavan added bug Something isn't working PSAT Features and tasks related to DevTools extension labels Dec 29, 2023
@maitreyie-chavan maitreyie-chavan modified the milestones: v0.4.1, v0.5.0 Dec 29, 2023
@mayan-000 mayan-000 moved this from Todo to In Progress in PS Analysis Tool Jan 5, 2024
@mayan-000 mayan-000 moved this from In Progress to In QA in PS Analysis Tool Jan 5, 2024
@kjnanda
Copy link
Author

kjnanda commented Jan 8, 2024

@mayan-000 Could you please check the below scenario where I have tried to show case the use case of toggling the random columns and how it shrinks the Domain columns width. This can happen to any column.

Visual-1

Screen.Recording.2024-01-08.at.13.25.40.mov

Visual-2

Screen.Recording.2024-01-08.at.15.55.52.mov

Screenshot

PSAT - image

CLI - image

@kjnanda
Copy link
Author

kjnanda commented Jan 9, 2024

@mayan-000 This looks good now.

@mayan-000 mayan-000 linked a pull request Jan 9, 2024 that will close this issue
4 tasks
@kjnanda
Copy link
Author

kjnanda commented Jan 10, 2024

@mayan-000

For CLI I accidentally came to this scenario and found that UI fails to revert back to it original style while toggling the columns otherwise it looks.

Please check the below visual.

Screen.Recording.2024-01-10.at.16.11.58.mov

@maitreyie-chavan maitreyie-chavan changed the title [QA] UI fails to revert to its original style after the user clicks on Toggle All and performs the same action again [QA] UI doesn't revert to original style after users click Toggle All and repeats the action Jan 10, 2024
@kjnanda
Copy link
Author

kjnanda commented Jan 15, 2024

@mayan-000 The issue mentioned here seems working fine now. However, I have found that with the latest code pull, the vertical scroll bar is missing from PSAT Extension along with CLI.

Screen.Recording.2024-01-10.at.17.16.27.1.mov

@mayan-000 mayan-000 moved this from In QA to Release Ready in PS Analysis Tool Jan 24, 2024
@mayan-000 mayan-000 moved this from Release Ready to In QA in PS Analysis Tool Jan 24, 2024
@mayan-000 mayan-000 moved this from In QA to Under Review in PS Analysis Tool Jan 24, 2024
@pavanpatil1
Copy link
Collaborator

  • The table border is not properly visible the horizontal scroll is present.

Steps to reproduce:
Open any frame and do the horizontal scroll.

image


  • The blank table is visible for few seconds even though the cookies count and cookies are present while loading the page.

Steps to reproduce:

  1. Open any site and visit any site.
  2. Observe on the first frame for first few seconds the cookies table will not shown.
screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.01.30-13_02_14.webm

@kjnanda
Copy link
Author

kjnanda commented Feb 8, 2024

This has been addressed in V.0.5.0 Release.

@kjnanda kjnanda closed this as completed Feb 8, 2024
@github-project-automation github-project-automation bot moved this from Under Review to Done in PS Analysis Tool Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PSAT Features and tasks related to DevTools extension
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants