Do not assume admin URLs but rely on correct core logic instead

[felixarntz]

I'm getting various JS errors from the WP Admin service worker because my website uses a wp-content directory which is separate from the WordPress core directory (which also means home_url() is different from site_url().

The PWA plugin assumes certain directory structures in https://github.com/GoogleChromeLabs/pwa-wp/blob/develop/integrations/class-wp-service-worker-admin-assets-integration.php#L22, which are not a given; for example, my WP Admin is not at wp-admin but at wp/wp-admin, and similarly my wp-includes is at wp/wp-includes.

Example error:

PrecacheController.js:228 Uncaught (in promise) bad-precaching-response: bad-precaching-response :: [{"url":"https://mysite.com/wp-admin/images/privacy.png","status":404}]

(the URL should be https://mysite.com/wp/wp-admin/images/privacy.png

Since WordPress allows setting these URLs differently, I think that needs to be accounted for here too.

[felixarntz]

A potential solution would be to call admin_url() and includes_url(), taking the paths from there.

I'm also thinking due to the nature of the bug that it could be happening in multisites using subdirectories too (although that's just an assumption, I haven't confirmed).

[westonruter]

I suppose it would be good to fix, but per #403 this integration and the other integrations would be deprecated and removed.

[felixarntz]

@westonruter Ah makes sense, thanks. Is this planned for 0.7? And just to clarify, deprecation or removal? Would they be unhooked from the filter but remain in place initially?

[westonruter]

Deprecation on 0.7 and removal in 0.8 I suppose.