-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the manifest from iOS to allow OAuth redirect to works #15
Comments
Some considerations about iOS: https://medium.com/@firt/you-shouldnt-use-chrome-s-pwacompat-library-in-your-progressive-web-apps-6b3496faab62 |
For what i could see, the issue is with the manifest (iOS implementation) and not with the |
Unfortunately, I think this hack doesn't seem to work anymore. I was just testing it out with my own app on iOS simulator (12.1) and all external links still open safari instead, even without the manifest available. Not sure if something has changed. Tried this without the added complexity of pwacompat, still no dice. Was really hoping to get SSO working but without the redirect, I'm going to have to find another route. |
I just hit this same issue - Auth with redirect is fine for Google and FB within Safari, but as soon as you add the PWA to the homescreen, the Auth process opens in Safari then tries to redirect to Safari too - leaving the PWA un-auth'd. Bugger. |
So this seems to me to be a fundamental problem with the way iOS uses PWAs; it's not really anything to do with PWACompat except for the fact that PWACompat configures iOS on your behalf. I'm not against having a "no-on-ios" modifier, but to me, the primary use-case of this library is to support iOS. So if PWAs aren't working on iOS because you have these kinds of auth flows, I'd probably suggest not using PWACompat for the time being. |
In exciting news, looks like new Safari betas might resolve this issue. |
For me, I wish to have the manifest in place for non-iOS users and have my site open in browser for iOS users until apple get their act together. |
If that's the case, the JavaScript suggested above could be included in your own bundle or inline in the HTML. This just really isn't a PWACompat issue ¯\_(ツ)_/¯ |
Indeed I have included the above code, it is working very well. As soon as these Safari issues are resolved by Apple I can go back to using PWACompat for my poor iOS users :o for now they will be using our system in a Safari window. |
Thanks @samthor. I can confirm that iOS 12.2.0 fixes the issue for us. 🎉🎉🎉 |
Lot of people are having issue with redirect at OAuth flow when using the apple-mobile-web-app-capable feature of iOS:
So, i believe that this pice of code could be inside pwacompat.js to allow many of PWAs use OAuth login:
At least until apple fix this issue (don't know where or if is been tracked).
The text was updated successfully, but these errors were encountered: