Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change use of abortable for doAbortable #1028

Open
jakearchibald opened this issue May 24, 2021 · 1 comment
Open

Change use of abortable for doAbortable #1028

jakearchibald opened this issue May 24, 2021 · 1 comment
Assignees
@jakearchibald

Comments

@jakearchibald
Copy link
Collaborator

Right now you kinda have to call assertSignal, and then abortable. A function that does both would be better.

I did some of this in #954, but a full solution would also allow the abort steps to be async.
@jakearchibald jakearchibald self-assigned this May 24, 2021
@jakearchibald jakearchibald mentioned this issue May 24, 2021
Merged
@jakearchibald
Copy link
Collaborator Author

I've updated my implementation in whatwg/dom#946 (comment) to be more like what we should probably use here.

@jakearchibald jakearchibald reopened this May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakearchibald jakearchibald

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jakearchibald