New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make controller SchemeGroupVersion a var #3

Closed

markmandel opened this issue Dec 7, 2017 · 1 comment

Labels

good first issue kind/cleanup

Milestone

Collaborator

markmandel commented Dec 7, 2017

It would be nice if the SchemeGroupVersion on line:
https://github.com/googleprivate/agon/blob/master/gameservers/controller/controller.go#L247

Was a var at the top of the controller. Saves it being recreated on each run through.

markmandel added good first issue kind/cleanup kind/design and removed kind/design labels

Collaborator Author

markmandel commented Jan 3, 2018

Closing since, we moved the CRD installation to install.yaml - this isn't around anymore.

markmandel closed this as completed

markmandel mentioned this issue

Target for generating a CHANGELOG from GitHub Milestones. #217

Merged

markmandel added this to the 0.1 milestone

markmandel mentioned this issue

Proposal: Multi-Cluster Allocation Policies #597

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment