Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move WaitForEstablishedCRD into central crd package #108

Merged
merged 1 commit into from
Feb 27, 2018

Conversation

markmandel
Copy link
Collaborator

Make this reusable as we are adding more CustomResourceDefinitions

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Feb 25, 2018
@markmandel markmandel added this to the 0.1 milestone Feb 25, 2018
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena
Copy link
Collaborator

You need to merge master though

@markmandel markmandel force-pushed the refactor/crd-established branch from 2f39ce5 to 15e7bea Compare February 27, 2018 00:55
Make this reusable as we are adding more CustomResourceDefinitions
@markmandel markmandel force-pushed the refactor/crd-established branch from 15e7bea to af9da96 Compare February 27, 2018 01:18
@markmandel markmandel merged commit 61af7cb into master Feb 27, 2018
@markmandel markmandel deleted the refactor/crd-established branch February 27, 2018 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants