Documentation on the CI build system.

[markmandel]

From #149 - realised we needed at least a note explaining how the build system works.

[markmandel]

/cc @pondohva I added some details on the current CI system, PTAL and see if anything else needs to be added.

[agones-bot]

Build Succeeded 👏

Build Id: 545d36fd-2631-4d6e-83c9-9aa8ca13716f

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.2-e31b624
• image: gcr.io/agones-images/agones-sdk:0.2-e31b624
• Linux C++ Build (dev): agonessdk-0.2-e31b624-dev-linux-arch_64.tar.gz
• Linux C++ Build (runtime): agonessdk-0.2-e31b624-runtime-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.2-e31b624.zip

[agones-bot]

Build Succeeded 👏

Build Id: b88ca62e-4e8d-4dd8-87c1-eea07b2995c9

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.2-f97d205
• image: gcr.io/agones-images/agones-sdk:0.2-f97d205
• Linux C++ Build (dev): agonessdk-0.2-f97d205-dev-linux-arch_64.tar.gz
• Linux C++ Build (runtime): agonessdk-0.2-f97d205-runtime-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.2-f97d205.zip

[agadelshin]

There is nice example we can adopt for helm chart https://github.com/kubernetes/charts/tree/master/test/circle

For helm we need to have a:

1. CI system where we can run lint and package commands
2. storage (I prefer google cloud storage for this, also we can use github pages or smth else)

Also, we can contribute to kubernetes/charts repo agones helm chart from #149. This repo is a common place to look for helm charts, they provide CI system and 2 repos: https://kubernetes-charts.storage.googleapis.com and https://kubernetes-charts-incubator.storage.googleapis.com

[agadelshin]

nice!

[agadelshin]

We need to add go lint/go vet and tests for golang code also.

[markmandel]

@pondohva we run the go tests on every build, see here in the cloudbuild.yaml.

While gometalinter is part of the build image (and therefore shell), I'm reticent to make it part of the test/build pipeline, just because of the propensity for it to raise false positives, and also because it doesn't ignore generated files - of which there are quite a few in this project between gRPC and generated CRD apis. (Also see this issue).

That being said, if you feel that there are places in which we can do a more on the testing front - or feel you have a way to work around the above issues, definitely submit a PR to the cloudbuild.yaml and supporting test suite.

[cyriltovena]

I agree with @pondohva we should have a CI for the helm package when #149 is closed.

issue created #153

[markmandel]

Any reason I can't get an approval on this PR though, so I can get it merged? 😄

[cyriltovena]

LGTM

[markmandel]

Thanks!