Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Go example into multi-stage Docker build #320

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Convert Go example into multi-stage Docker build #320

merged 1 commit into from
Aug 14, 2018

Conversation

markmandel
Copy link
Collaborator

Reducing dependencies to working with the examples, this has been converted into a multi stage Docker build.

This also removes the client, as nobody is using it, as netcat works perfectly.

@markmandel
Convert Go example into multi-stage Docker build
9f185d7 
Reducing dependencies to working with the examples,
this has been converted into a multi stage Docker build.

This also removes the client, as nobody is using it,
as netcat works perfectly.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/examples Examples. Usually found in the `examples` directory labels Aug 14, 2018
@markmandel markmandel added this to the 0.4.0 milestone Aug 14, 2018
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ef6a0584-603f-4cad-ab63-956e121ba4b8

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/320/head:pr_320 && git checkout pr_320
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.4.0-9f185d7

@markmandel markmandel merged commit d5062ce into googleforgames:master Aug 14, 2018
@markmandel markmandel deleted the feature/multi-stage-build branch August 14, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricFortin EricFortin EricFortin approved these changes

Assignees
No one assigned
Labels
area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @EricFortin