e2e tests for Fleet Scaling and Updates #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
added
the
area/build-tools
|
Build Succeeded 👏 Build Id: a9c26012-9122-4d8f-88ff-f802364941fa The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
|
Yes, these are surely coming in handy |
EricFortin
reviewed
Sep 11, 2018
test/e2e/fleet_test.go
Outdated
|
|
||
| // remove allocation | ||
| gp := int64(1) | ||
| err = alpha1.GameServers(defaultNs).Delete(fa.Status.GameServer.ObjectMeta.Name, &metav1.DeleteOptions{GracePeriodSeconds: &gp}) |
There was a problem hiding this comment.
Comment says remove allocation but I (mis)understand it deletes a game server. Am I right?
There was a problem hiding this comment.
Good point - it's deleting the allocated game server. Changing the comment to be more clear.
EricFortin
approved these changes
Sep 11, 2018
Also includes some functionality for making e2e tests with fleets a bit easier as well.
markmandel
force-pushed
the
e2e/fleet-updates
branch
from
426b0df to
9ff3d45
Compare
|
Build Succeeded 👏 Build Id: 241b2120-42f1-4f76-a3b9-722d7a533faf The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some functionality for making e2e tests with fleets a bit easier as well.