fix: update blueprint-test for kpt v1.0.0-beta.16+ #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeabody
requested review from
bharathkkb,
ocsig and
g-awmalik
as code owners
bharathkkb
approved these changes
Jan 13, 2023
apeabody
force-pushed
the
ap-patch-57w
branch
5 times, most recently
from
c3f1fb4 to
7560617
Compare
apeabody
force-pushed
the
ap-patch-57w
branch
from
7560617 to
7e13f11
Compare
bharathkkb
reviewed
Jan 17, 2023
bharathkkb
approved these changes
Jan 24, 2023
apeabody
commented
Jan 24, 2023
apeabody
commented
Jan 24, 2023
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
apeabody
force-pushed
the
ap-patch-57w
branch
from
03669b6 to
0ff5c1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:
kpt live applyno longer includes "unchanged" status, so this somewhat changes the behavior ofDefaultVerifyto verify all are applied successfully. If the verification of "unchanged" status is used by other consumers (@kaariger) of this package we should revisit the design.Tested with
go test -v krm_simple_blueprint_test.goFixes: #1190