Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devtools builds failing due to addlicense #973

Closed
bharathkkb opened this issue Aug 11, 2021 · 0 comments · Fixed by #975
Closed

Devtools builds failing due to addlicense #973

bharathkkb opened this issue Aug 11, 2021 · 0 comments · Fixed by #975

Comments

@bharathkkb
Copy link
Member

A recent addition to google/addlicense#84 requires go1.16 and our current base image uses 1.15. We should probably bump our image to use 1.16 and then pin addlicense to prevent future breakages.

Failed build: https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/actions/runs/1118552920

/cc @Shabirmean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: bump goversion, pin addlicense GoogleCloudPlatform/cloud-foundation-toolkit
1 participant
@bharathkkb