Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding a check for null http handler before starting the server #138

Merged
merged 5 commits into from
Jun 21, 2022

Conversation

kappratiksha
Copy link
Contributor

No description provided.

@kappratiksha kappratiksha requested review from grant, anniefu and a team June 16, 2022 17:54
funcframework/framework.go Outdated Show resolved Hide resolved
funcframework/framework.go Show resolved Hide resolved
funcframework/framework.go Show resolved Hide resolved
funcframework/framework_test.go Outdated Show resolved Hide resolved
funcframework/framework_test.go Outdated Show resolved Hide resolved
funcframework/framework.go Outdated Show resolved Hide resolved
@kappratiksha kappratiksha changed the title adding a check for null http handler before starting the server fix: adding a check for null http handler before starting the server Jun 18, 2022
@kappratiksha kappratiksha requested review from anniefu and grant June 21, 2022 17:40
funcframework/framework_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@anniefu anniefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for addressing all the comments!

funcframework/framework.go Outdated Show resolved Hide resolved
funcframework/framework_test.go Outdated Show resolved Hide resolved
funcframework/framework.go Outdated Show resolved Hide resolved
funcframework/framework_test.go Outdated Show resolved Hide resolved
@kappratiksha kappratiksha merged commit 5d5bf7a into master Jun 21, 2022
@anniefu anniefu linked an issue Jun 24, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add empty registry error on funcframework.Start
3 participants