Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing package.json fields, warnings like "npm WARN functions-framework@ No description" #257

Closed
techieshark opened this issue Mar 2, 2021 · 5 comments
Assignees

Comments

@techieshark
Copy link

I'm looking at the cloud build logs while debugging a failed gcloud functions deploy. I came across these warnings, which I am certain have nothing to do with the issue I'm investigating, but in any case it'd be nice to get distracted by functions framework warnings.

Possible to update these missing fields (license, description, repo etc)?

image

Calling attention to these specific lines:

npm WARN functions-framework@ No license field.
npm WARN functions-framework@ No repository field.
npm WARN functions-framework@ No description
@techieshark techieshark changed the title Missing package.json fields - leading to warnings? Missing package.json fields, warnings like "npm WARN functions-framework@ No description" Mar 2, 2021
@grant
Copy link
Contributor

grant commented Mar 2, 2021

Hi,
I don't know exactly where these logs are coming from.
The package is not functions-framework@. The package is @google-cloud/functions-framework. Maybe that is your code? Can you share your code?

We have these fields in the framework here:
https://github.com/GoogleCloudPlatform/functions-framework-nodejs/blob/master/package.json

@grant grant self-assigned this Mar 2, 2021
@grant
Copy link
Contributor

grant commented Mar 2, 2021

It might be an issue in the buildpack.

@techieshark
Copy link
Author

Maybe that is your code? Can you share your code?

Hi @grant, I sent an email to the gmail address I found on your website. I hope that helps.

Thanks!

@grant
Copy link
Contributor

grant commented Mar 9, 2021

I'm not sure if this issue has been triaged or is related to this other issue:

#258 (comment)

I can't personally debug issues like this via email. It seems like things are alright and there are no immediate issues from this npm module. As such, closing.

If there's still an issue with this module, please provide exact minimal repro steps here. Thanks!

@grant grant closed this as completed Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants