Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Code of Conduct #162

Closed
wants to merge 1 commit into from
Closed

Conversation

blowmage
Copy link

Gcloud is adopting a Code of Conduct. This PR adds the Code of Conduct that was agreed upon in GoogleCloudPlatform/gcloud-common#23.

@broady
Copy link
Contributor

broady commented Aug 25, 2015

The Go community will soon have a code of conduct:
https://groups.google.com/forum/#!msg/golang-nuts/sy-YcVPADjg/bcO6LAr29EIJ

I think it makes sense to use this code of conduct in the interim.

I'd prefer to see this text appended to CONTRIBUTING.md, or to README.md, though.

Thoughts, @okdave @adg ?

@adg
Copy link
Contributor

adg commented Aug 25, 2015

CODE_OF_CONDUCT.md is an ugly file name. I would prefer it to be CONDUCT.md.

@blowmage
Copy link
Author

AFAICT the majority of projects that have adopted this CoC have used this name. Folks who are scanning repos for a code of conduct will most likely be looking for this file. The Contributor Covenant site even expresses a preference for this file name:

Pledge your respect and appreciation for contributors and participants in your open source project by adding an explicit CODE_OF_CONDUCT.md to your project repository.

However, some projects have added the CoC contents to the CONTRIBUTING.md file instead.

@adg
Copy link
Contributor

adg commented Aug 27, 2015

OK, let's add it to CONTRIBUTING.md. I can't bring myself to add such a
gross file name to the repo root.

On 26 August 2015 at 09:28, Mike Moore notifications@github.com wrote:

AFAICT the majority of projects that have adopted this CoC have used this
name. Folks who are scanning repos for a code of conduct will most likely
be looking for this file. The Contributor Covenant
http://contributor-covenant.org/ site even expresses a preference for
this file name:

Pledge your respect and appreciation for contributors and participants in
your open source project by adding an explicit CODE_OF_CONDUCT.md to your
project repository.

However, some projects have added the CoC contents to the CONTRIBUTING.md
file instead.


Reply to this email directly or view it on GitHub
#162 (comment)
.

@blowmage
Copy link
Author

Updated the PR. Moved the content to the contributing guide and added a note about the code of conduct to the readme.

@gmlewis
Copy link
Contributor

gmlewis commented Aug 27, 2015

We don't use pull-requests in this repo, but instead use Gerrit.
See CONTRIBUTING.md for details.
I'm putting together a Gerrit CL for these changes and will leave this issue open until the CL is checked in.

@gmlewis
Copy link
Contributor

gmlewis commented Aug 27, 2015

gmlewis added a commit that referenced this pull request Sep 8, 2015
This fixes issue #162.

Change-Id: I839a42fa6df5ed8eaef7cf1a0a4cd77d8bbd3baf
@broady broady closed this Sep 8, 2015
rakyll pushed a commit that referenced this pull request Nov 16, 2016
This has one significant change for Sentiment Analysis:
polarity is dropped and replaced by score.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants