You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While testing code changes @shubham-diwakar and I came across that the linter used for gcsfuse does not inspect existing files that are already committed and only changes in a PR.
Example:
Error: Error return value of `util.Unmount` is not checked (errcheck)
Error: Error return value of `util.Unmount` is not checked (errcheck)
Error: Error return value of `util.Unmount` is not checked (errcheck)
Error: Error return value of `cmd.Wait` is not checked (errcheck)
Error: Error return value of `cmd.Process.Kill` is not checked (errcheck)
Linter workflow needs to be updated to also lint existing code as well. This came up with in forked repo setup and filing an issue here since this is the source of truth.
The text was updated successfully, but these errors were encountered:
While testing code changes @shubham-diwakar and I came across that the linter used for gcsfuse does not inspect existing files that are already committed and only changes in a PR.
Example:
Linter workflow needs to be updated to also lint existing code as well. This came up with in forked repo setup and filing an issue here since this is the source of truth.
The text was updated successfully, but these errors were encountered: