Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linter for all Go code #2687

Open
frankyn opened this issue Nov 14, 2024 · 0 comments
Open

Update linter for all Go code #2687

frankyn opened this issue Nov 14, 2024 · 0 comments
Labels
cleanup Internal Cleanup: internal reminder to clean up debt p2 P2

Comments

@frankyn
Copy link
Member

frankyn commented Nov 14, 2024

While testing code changes @shubham-diwakar and I came across that the linter used for gcsfuse does not inspect existing files that are already committed and only changes in a PR.

Example:

Error: Error return value of `util.Unmount` is not checked (errcheck)
  Error: Error return value of `util.Unmount` is not checked (errcheck)
  Error: Error return value of `util.Unmount` is not checked (errcheck)
  Error: Error return value of `cmd.Wait` is not checked (errcheck)
  Error: Error return value of `cmd.Process.Kill` is not checked (errcheck)

Linter workflow needs to be updated to also lint existing code as well. This came up with in forked repo setup and filing an issue here since this is the source of truth.

@frankyn frankyn added cleanup Internal Cleanup: internal reminder to clean up debt p2 P2 labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal Cleanup: internal reminder to clean up debt p2 P2
Projects
None yet
Development

No branches or pull requests

1 participant