jgeewax/cli uses wrong import paths, fails tests

[stapelberg]

@jgeewax I would’ve filed this in https://github.com/jgeewax/cli, but you’ve disabled GitHub issues for that project :(.

I’m currently packaging github.com/jgeewax/cli for Debian as a dependency of gcsfuse. I’ve noticed that *_test.go still refers to codegangsta/cli, which implies that codegangsta/cli must also be present at a compatible version (!). I think this is a mistake.

Further, even after fixing the import paths, the tests fail:

=== RUN TestStringFlagHelpOutput
--- FAIL: TestStringFlagHelpOutput (0.00s)
    flag_test.go:51: --help      (default: "") does not match --help    
    flag_test.go:51: -h      (default: "") does not match -h    
    flag_test.go:51: -h      (default: "") does not match -h    
    flag_test.go:51: --test      (default: "Something") does not match --test "Something"   
=== RUN TestStringFlagWithEnvVarHelpOutput
--- PASS: TestStringFlagWithEnvVarHelpOutput (0.00s)
=== RUN TestStringSliceFlagHelpOutput
--- PASS: TestStringSliceFlagHelpOutput (0.00s)
=== RUN TestStringSliceFlagWithEnvVarHelpOutput
--- PASS: TestStringSliceFlagWithEnvVarHelpOutput (0.00s)
=== RUN TestIntFlagHelpOutput
--- FAIL: TestIntFlagHelpOutput (0.00s)
    flag_test.go:136: --help     (default: 0) does not match --help "0" 
    flag_test.go:136: -h     (default: 0) does not match -h "0" 
=== RUN TestIntFlagWithEnvVarHelpOutput
--- PASS: TestIntFlagWithEnvVarHelpOutput (0.00s)
=== RUN TestDurationFlagHelpOutput
--- FAIL: TestDurationFlagHelpOutput (0.00s)
    flag_test.go:169: --help     (default: "0") does not match --help "0"   
    flag_test.go:169: -h     (default: "0") does not match -h "0"   
=== RUN TestDurationFlagWithEnvVarHelpOutput
--- PASS: TestDurationFlagWithEnvVarHelpOutput (0.00s)
=== RUN TestIntSliceFlagHelpOutput
--- PASS: TestIntSliceFlagHelpOutput (0.00s)
=== RUN TestIntSliceFlagWithEnvVarHelpOutput
--- PASS: TestIntSliceFlagWithEnvVarHelpOutput (0.00s)
=== RUN TestFloat64FlagHelpOutput
--- FAIL: TestFloat64FlagHelpOutput (0.00s)
    flag_test.go:242: --help     (default: 0) does not match --help "0" 
    flag_test.go:242: -h     (default: 0) does not match -h "0" 
=== RUN TestFloat64FlagWithEnvVarHelpOutput
--- PASS: TestFloat64FlagWithEnvVarHelpOutput (0.00s)
=== RUN TestGenericFlagHelpOutput
--- FAIL: TestGenericFlagHelpOutput (0.00s)
    flag_test.go:276: "--test \ttest flag (default: \"abc,def\")" does not match "--test \"abc,def\"\ttest flag"
    flag_test.go:276: "-t \ttest flag (default: \"abc,def\")" does not match "-t \"abc,def\"\ttest flag"

@jgeewax Can you please take a look at both issues?

[jgeewax]

Thanks for letting me know -- I just noticed that forks don't have issues turned on by default? Fixed that....

I'll take a look -- PRs would be super welcome though !