Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speech: update to v1 #2175

Merged
merged 2 commits into from
Apr 3, 2017

Conversation

stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Apr 1, 2017

Update the Speech API to v1.

@stephenplusplus stephenplusplus added the api: vision Issues related to the Cloud Vision API. label Apr 1, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2017
@stephenplusplus stephenplusplus added api: speech Issues related to the Speech-to-Text API. and removed api: vision Issues related to the Cloud Vision API. labels Apr 1, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e207b93 on stephenplusplus:spp--vision-v1 into 6c345d2 on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus removed the request for review from jmuk April 3, 2017 17:24
Copy link
Contributor

@callmehiphop callmehiphop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - my only question would be why are we including the gapic tests here?

@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Apr 3, 2017

Not sure: #1930

@lukesneeringer
Copy link
Contributor

For now, my vote is to leave them included (they may or may not actually run). We are working on a longer-term testing strategy for these.

It is worth noting that while the development does not happen here, this is more or less the canonical location for GAPICs. :-/

I think the best way to do that ultimately is to have the generation process make a PR to this repo, and have the tests run that way, and rely less on api-client-staging as a canonical location.

@stephenplusplus stephenplusplus merged commit 6f39cb4 into googleapis:master Apr 3, 2017
@stephenplusplus
Copy link
Contributor Author

That's cool.

@@ -492,6 +432,12 @@ Speech.prototype.createRecognizeStream = function(config) {
throw new Error('A recognize request requires a configuration object.');
}

config = extend(true, {
config: {
languageCode: 'en-US'

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: speech Issues related to the Speech-to-Text API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants