-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speech: update to v1 #2175
speech: update to v1 #2175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - my only question would be why are we including the gapic tests here?
Not sure: #1930 |
For now, my vote is to leave them included (they may or may not actually run). We are working on a longer-term testing strategy for these. It is worth noting that while the development does not happen here, this is more or less the canonical location for GAPICs. :-/ I think the best way to do that ultimately is to have the generation process make a PR to this repo, and have the tests run that way, and rely less on api-client-staging as a canonical location. |
That's cool. |
@@ -492,6 +432,12 @@ Speech.prototype.createRecognizeStream = function(config) { | |||
throw new Error('A recognize request requires a configuration object.'); | |||
} | |||
|
|||
config = extend(true, { | |||
config: { | |||
languageCode: 'en-US' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Update the Speech API to v1.