-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a test for app deployment failure propagation #92
Comments
I created a simple test for this here: https://github.com/GoogleCloudPlatform/jetty-runtime/tree/issue-92 However it doesn't fail based on the current state of master, at least by my reckoning. A badly formatted web.xml should result in the failure of the deployment, right? |
The scenario I've tested was referencing a non-existing class for a servlet definition in web.xml. That did cause a failure during deployment. |
that works, I'll update the test and look into why the other way wasn't working |
@meltsufin are you still interested in a test like this? it means another maven artifact in tests |
Sure, another maven artifact could open a whole can of warms with our current test setup though. We'll need to tackle it at some point anyway. |
See: #91
The text was updated successfully, but these errors were encountered: