Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage files missing for some tests #1435

Closed
fhinkel opened this issue Jul 29, 2019 · 5 comments
Closed

Storage files missing for some tests #1435

fhinkel opened this issue Jul 29, 2019 · 5 comments
Assignees

Comments

@fhinkel
Copy link
Contributor

fhinkel commented Jul 29, 2019

Hi, could you have a look, this is blocking us from merging PRs. The OCR and imagemagick tests are failing because zombies.jpg isn't in the storage bucket. Thanks

@ace-n
Copy link
Contributor

ace-n commented Jul 29, 2019

This image keeps getting deleted for some reason, and I can't seem to figure out why. (Maybe the Node 6 sample tests? 🤔 Current versions of functions/imagemagick and functions/ocr should only delete from the nodejs-docs-samples-tests-functions bucket, not nodejs-docs-samples-tests.)

In the meantime, I've enabled a hold on it - if the deletion is caused by an automated process, this should (hopefully) cause said process to "halt and catch fire".

Failing that, we can set up GCS access logging for this bucket. (I wasn't able to find anything in Stackdriver, unfortunately.)

@fhinkel
Copy link
Contributor Author

fhinkel commented Jul 30, 2019

The ocr test is still failing:

Detected language "und" for wakeupcat.jpg
Looking for text in image wakeupcat.jpg
Extracted text from image:
Detected language "und" for wakeupcat.jpg
File wakeupcat.jpg processed.

Looks like we're not detecting the test on the image anymore. Not sure if the algorithm changed or if we're calling the API incorrectly.

@fhinkel
Copy link
Contributor Author

fhinkel commented Jul 31, 2019

Turns out the image is not in the storage bucket.

@fhinkel fhinkel changed the title OCR and imagemagick CI started failing Storage files missing for some tests Jul 31, 2019
@ace-n
Copy link
Contributor

ace-n commented Jul 31, 2019

Restored wakeupcat.jpg. Also enabled a hold, so any automated deletion attempt should fail.

@fhinkel
Copy link
Contributor Author

fhinkel commented Jul 31, 2019

Thank you, tests are passing 😄

@fhinkel fhinkel closed this as completed Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants